Remove YSU theta -> t -> theta tendency computations #10
+2
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of the ysu subroutine, this mod removes the computation that switches the temperature tendency to a potential temperature tendency. We make that change because inside of the bl_ysu_run subroutine, we removed the computation that changed the potential temperature tendency to a temperature tendency. At the end of the bl_ysu_run routine, we have a potential temperature tendency. There is no need to temporarily convert this to a temperature tendency, only to reconvert it back to a potential temperature tendency immediately after the routine exits. As expected, this change causes bit-for-bit differences. This change was not included in the sequence of ysu mods that give bit-wise identical results so as to allow the far larger code modifications to be validated more easily. Both MPAS and WRF physics developers OK'ed this modification. Both MPAS and WRF physics schemes expect to handle potential temperature tendencies coming out of the PBL scheme from phyics. Advantages: 1. No need to do reciprocal computations to get back to the same state variable (algebraically the same). 2. The trailing computation in the ysu scheme (which is now removed) would have required an extra CPF interstitial routine. modified: src/core_atmosphere/physics/physics_sima/bl_ysu.F
ldfowler58
pushed a commit
that referenced
this pull request
Jun 7, 2022
KEYWORDS: halo exchange, adjoint DESCRIPTION OF CHANGES: * This is a companion of JCSDA/mpas-jedi#361 . * `stream_function` and `velocity_potential` are added to Registry as a `jedi-da` package. * Adjoint of halo exchange is added (`mpas_dmpar_exch_halo_adj_field`). Only `mpas_dmpar_exch_halo_adj_field2d_real` was written because this is what is really used in JCSDA/mpas-jedi#361 . LIST OF MODIFIED FILES: M src/core_atmosphere/Registry.xml M src/framework/mpas_dmpar.F
ldfowler58
pushed a commit
that referenced
this pull request
Jun 7, 2022
This alters the signature of the mpas_init subroutine in mpas_subdriver.F, adding two optional parameters that allow the caller to pass in filenames for the namelist and streams file. This allows the caller to specify different files to be used, other than namelist.atmosphere and streams.atmosphere in the working directory. This functionality is critical for several use-cases in MPAS-JEDI, including the ConvertState application, which interpolates data between two MPAS meshes of different resolutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the ysu subroutine, this mod removes the computation
that switches the temperature tendency to a potential temperature
tendency.
We make that change because inside of the bl_ysu_run subroutine, we
removed the computation that changed the potential temperature
tendency to a temperature tendency.
At the end of the bl_ysu_run routine, we have a potential temperature
tendency. There is no need to temporarily convert this to a temperature
tendency, only to reconvert it back to a potential temperature
tendency immediately after the routine exits.
As expected, this change causes bit-for-bit differences. This change
was not included in the sequence of ysu mods that give bit-wise identical
results so as to allow the far larger code modifications to be validated
more easily.
Both MPAS and WRF physics developers OK'ed this modification. Both
MPAS and WRF physics schemes expect to handle potential temperature
tendencies coming out of the PBL scheme from phyics.
Advantages:
state variable (algebraically the same).
would have required an extra CPF interstitial routine.
modified: src/core_atmosphere/physics/physics_sima/bl_ysu.F